add optional deps #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jess-farmer
requested changes
Feb 26, 2025
Comment on lines
36
to
46
| Creates the scipy curve fit engine class | ||
| Stores useful information about each fit | ||
| :param name: name of the fit engine | ||
| :param x_data: original x data (can fit to an interpolation) | ||
| :param y_data: original y data (can fit to an interpolation) | ||
| :param e_data: original e data (can fit to an interpolation) | ||
| :param lower: the lower bounds for the fit parameters | ||
| :param upper: the upper bounds for the fit parameters | ||
| :param samples: the number of samples to use in multistart | ||
| :param max_iterations: the maximum number of iterations for the fit | ||
| """ |
There was a problem hiding this comment.
I think it would be worth updating this docstring to reflect the fact that the gofit engine isn't created in this case?
|
All tests run as expected for me, just a couple of comments on docstrings |
AnthonyLim23
commented
Feb 26, 2025
Co-authored-by: Jessica Huntley <[email protected]>
jess-farmer
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes gofit to be an optional dependency. I have edited the tests such that:
I have written the code so the gofit fitting engine gives an error on initialisation if gofit is not installed.